Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart

Issue 1285173002: dart2js cps: Rewrite more List operations into JS array operations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: receiverIsNotNull -> optional param Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart
diff --git a/pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart b/pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart
index 399b972928ecda0a83224c962eb0ffe009b31ef2..3fa61dd22b4d1e5d8f4f58f26164fa4398048d87 100644
--- a/pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart
+++ b/pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart
@@ -491,6 +491,21 @@ class StatementRewriter extends Transformer implements Pass {
return node;
}
+ Expression visitApplyBuiltinMethod(ApplyBuiltinMethod node) {
+ if (node.receiverIsNotNull) {
+ _rewriteList(node.arguments);
+ node.receiver = visitExpression(node.receiver);
+ } else {
+ // Impure expressions cannot be propagated across the method lookup,
+ // because it throws when the receiver is null.
+ inEmptyEnvironment(() {
+ _rewriteList(node.arguments);
+ });
+ node.receiver = visitExpression(node.receiver);
+ }
+ return node;
+ }
+
Expression visitInvokeMethodDirectly(InvokeMethodDirectly node) {
_rewriteList(node.arguments);
node.receiver = visitExpression(node.receiver);

Powered by Google App Engine
This is Rietveld 408576698