dart2js cps: Rewrite more List operations into JS array operations.

pkg/compiler/lib/src/js_backend/codegen/codegen.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_generator;
 
 import 'glue.dart';
 
 import '../../closure.dart' show ClosureClassElement;
 import '../../common/codegen.dart' show CodegenRegistry;
 import '../../constants/values.dart';
 import '../../dart_types.dart';
 import '../../diagnostics/invariant.dart' show invariant;
 import '../../diagnostics/spannable.dart' show CURRENT_ELEMENT_SPANNABLE;
 import '../../elements/elements.dart';
 import '../../io/source_information.dart' show SourceInformation;
 import '../../js/js.dart' as js;
 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
-import '../../tree_ir/tree_ir_nodes.dart' show BuiltinOperator;
+import '../../tree_ir/tree_ir_nodes.dart' show BuiltinOperator, BuiltinMethod;
 import '../../types/types.dart' show TypeMask;
 import '../../universe/universe.dart' show
     Selector,
     UniverseSelector;
 import '../../util/maplet.dart';
 
+/// The JS name of a built-in method.
+final Map<BuiltinMethod, String> BuiltinMethodName = <BuiltinMethod, String>{

[karlklose, 2015/08/12 13:00:46]

Identifiers for globals should start with a lower case. Also, we could make it
const (and maybe use an ALL_CAPS_NAME, if you like).

[asgerf, 2015/08/12 13:29:39]

Done. I also decided to make it static to put it closer to its use.

+  BuiltinMethod.Push: 'push',
+  BuiltinMethod.Pop: 'pop',
+};
+
 class CodegenBailout {
   final tree_ir.Node node;
   final String reason;
   CodegenBailout(this.node, this.reason);
   String get message {
     return 'bailout${node != null ? " on $node" : ""}: $reason';
   }
 }
 
 class CodeGenerator extends tree_ir.StatementVisitor
@@ skipping 791 matching lines @@
       case BuiltinOperator.IsNotNumber:
         return js.js("typeof # !== 'number'", args);
       case BuiltinOperator.IsFloor:
         return js.js("Math.floor(#) === #", args);
       case BuiltinOperator.IsNumberAndFloor:
         return js.js("typeof # === 'number' && Math.floor(#) === #", args);
     }
   }
 
   @override
+  js.Expression visitApplyBuiltinMethod(tree_ir.ApplyBuiltinMethod node) {
+    String name = BuiltinMethodName[node.method];
+    js.Expression receiver = visitExpression(node.receiver);
+    List<js.Expression> args = visitExpressionList(node.arguments);
+    return js.js('#.#(#)', [receiver, name, args]);
+  }
+
+  @override
   js.Expression visitAwait(tree_ir.Await node) {
     return new js.Await(visitExpression(node.input));
   }
 
   visitFunctionExpression(tree_ir.FunctionExpression node) {
     // FunctionExpressions are currently unused.
     // We might need them if we want to emit raw JS nested functions.
     throw 'FunctionExpressions should not be used';
   }
 }