Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1285133008: Remove obsolete SynthesizeScrollGesture method. (Closed)

Created:
5 years, 4 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 3 months ago
Reviewers:
Sami, pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete SynthesizeScrollGesture method. Tidy up after the interface change to Input.synthesizeScrollGesture Patch 4 of 4 to fix the overly long delay between each scroll in smoothness.scrolling_tough_ad_cases caused by the render thread being unresponsive. Patch 1: https://codereview.chromium.org/1299643004/ Patch 2: https://codereview.chromium.org/1296993002/ Patch 3: https://codereview.chromium.org/1291513004/ BUG=510398 Committed: https://crrev.com/3ea8e7a13495246cb44318c541df3be3945cacc3 Cr-Commit-Position: refs/heads/master@{#346624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M content/browser/devtools/protocol/input_handler.h View 1 chunk +0 lines, -12 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
alex clarke (OOO till 29th)
5 years, 4 months ago (2015-08-17 16:09:46 UTC) #2
Sami
That's a funny looking diff. Non-owner lgtm.
5 years, 4 months ago (2015-08-17 16:41:38 UTC) #3
alex clarke (OOO till 29th)
5 years, 4 months ago (2015-08-17 16:43:16 UTC) #5
pfeldman
lgtm
5 years, 4 months ago (2015-08-17 17:42:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285133008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285133008/1
5 years, 3 months ago (2015-09-01 10:16:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 11:10:57 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 11:11:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ea8e7a13495246cb44318c541df3be3945cacc3
Cr-Commit-Position: refs/heads/master@{#346624}

Powered by Google App Engine
This is Rietveld 408576698