ios: Fixing base_unittests to build with gn.

base/test/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
@@ skipping 19 matching lines @@
     "gtest_util.cc",
     "gtest_util.h",
     "gtest_xml_unittest_result_printer.cc",
     "gtest_xml_unittest_result_printer.h",
     "gtest_xml_util.cc",
     "gtest_xml_util.h",
     "histogram_tester.cc",
     "histogram_tester.h",
     "ios/wait_util.h",
     "ios/wait_util.mm",
-    "launcher/test_launcher.h",
     "launcher/test_result.cc",
     "launcher/test_result.h",
     "launcher/test_results_tracker.h",
     "launcher/unit_test_launcher.h",
     "mock_chrome_application_mac.h",
     "mock_chrome_application_mac.mm",
     "mock_devices_changed_observer.cc",
     "mock_devices_changed_observer.h",
     "mock_entropy_provider.cc",
     "mock_entropy_provider.h",
@@ skipping 61 matching lines @@
     "thread_test_helper.h",
     "trace_event_analyzer.cc",
     "trace_event_analyzer.h",
     "trace_to_file.cc",
     "trace_to_file.h",
     "user_action_tester.cc",
     "user_action_tester.h",
     "values_test_util.cc",
     "values_test_util.h",
   ]
-
+  if (!is_ios) {
+    sources += [
+      "launcher/test_launcher.cc",
+      "launcher/test_launcher.h",
+      "launcher/test_results_tracker.cc",
+      "multiprocess_test.cc",
+    ]
+  }

[Dirk Pranke, 2015/08/14 20:08:39]

if (!is_ios) {
  ...
}
if (is_ios) {
  ...
} else {
  ...
}

is awkward at best. Why not just move test_launcher.h down to the else clause
where the other lines were?

[sherouk, 2015/08/18 13:57:01]

Done.

   if (is_ios) {
     sources += [ "launcher/unit_test_launcher_ios.cc" ]
   } else {
     sources += [
-      "launcher/test_launcher.cc",
-      "launcher/test_results_tracker.cc",
       "launcher/unit_test_launcher.cc",
-      "multiprocess_test.cc",
       "multiprocess_test_android.cc",
     ]
   }
 
   configs += [ "//build/config:precompiled_headers" ]
 
   data = [
     # The isolate needs this script for setting up the test. It's not actually
     # needed to run this target locally.
     "//testing/test_env.py",
@@ skipping 73 matching lines @@
 
 if (is_android) {
   generate_jni("base_unittests_jni_headers") {
     sources = [
       "android/java/src/org/chromium/base/ContentUriTestUtils.java",
       "android/java/src/org/chromium/base/TestUiThread.java",
     ]
     jni_package = "base"
   }
 }