Refactor the code that creates the list of secondary accounts

chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #import "chrome/browser/ui/cocoa/browser/profile_chooser_controller.h"
 
 #include "base/mac/bundle_locations.h"
-#include "base/stl_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/avatar_menu.h"
 #include "chrome/browser/profiles/avatar_menu_observer.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_info_util.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/profiles/profile_window.h"
+#include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/signin/profile_oauth2_token_service.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/chrome_style.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
@@ skipping 543 matching lines @@
   [container addSubview:accountEmails];
   [container setFrameSize:NSMakeSize(
       NSWidth([container frame]), NSMaxY([accountEmails frame]))];
   return container.autorelease();
 }
 
 - (NSView*)createAccountsListWithRect:(NSRect)rect {
   base::scoped_nsobject<NSView> container([[NSView alloc] initWithFrame:rect]);
   currentProfileAccounts_.clear();
 
-  // The primary account should always be listed first.  However, the vector
-  // returned by ProfileOAuth2TokenService::GetAccounts() will contain the
-  // primary account too.  Ignore it when it appears later.
-  // TODO(rogerta): we still need to further differentiate the primary account
-  // from the others, so more work is likely required here: crbug.com/311124.
   Profile* profile = browser_->profile();
-
-  // TODO(noms): This code is duplicated by the views implementation. See
-  // crbug.com/331805.
   std::string primaryAccount =
       SigninManagerFactory::GetForProfile(profile)->GetAuthenticatedUsername();
   DCHECK(!primaryAccount.empty());
-  std::vector<std::string> accounts =
-      ProfileOAuth2TokenServiceFactory::GetForProfile(profile)->GetAccounts();
-  DCHECK_EQ(1, std::count_if(accounts.begin(), accounts.end(),
-                             std::bind1st(std::equal_to<std::string>(),
-                                          primaryAccount)));
+  std::vector<std::string>accounts =
+      profiles::GetSecondaryAccountsForProfile(profile, primaryAccount);
+
   rect.origin.y = 0;
   for (size_t i = 0; i < accounts.size(); ++i) {
     // Save the original email address, as the button text could be elided.
     currentProfileAccounts_[i] = accounts[i];
-    if (primaryAccount != accounts[i]) {
-      NSButton* accountButton = [self makeAccountButtonWithRect:rect
-                                                          title:accounts[i]
-                                                   canBeDeleted:true];
-      [accountButton setTag:i];
-      [container addSubview:accountButton];
-      rect.origin.y = NSMaxY([accountButton frame]) + kSmallVerticalSpacing;
-    }
+    NSButton* accountButton = [self makeAccountButtonWithRect:rect
+                                                        title:accounts[i]
+                                                 canBeDeleted:true];
+    [accountButton setTag:i];
+    [container addSubview:accountButton];
+    rect.origin.y = NSMaxY([accountButton frame]) + kSmallVerticalSpacing;
   }
 
-  // Add the primary account button. It doesn't need a tag, as it cannot be
-  // removed.
+  // The primary account should always be listed first. It doesn't need a tag,
+  // as it cannot be removed.
+  // TODO(rogerta): we still need to further differentiate the primary account
+  // from the others, so more work is likely required here: crbug.com/311124.

[Alexei Svitkine (slow), 2014/01/08 21:28:37]

Should this TODO be in the utility function? Or does this mean differentiate in
the UI? If so, please clarify the comment.

[noms (inactive), 2014/01/08 21:35:13]

Differentiate in the UI. Fixed.
On 2014/01/08 21:28:37, Alexei Svitkine wrote:

   NSButton* accountButton = [self makeAccountButtonWithRect:rect
                                                       title:primaryAccount
                                                canBeDeleted:false];
   [container addSubview:accountButton];
   [container setFrameSize:NSMakeSize(NSWidth([container frame]),
                                      NSMaxY([accountButton frame]))];
   return container.autorelease();
 }
 
 - (NSView*) createGaiaEmbeddedView {
@@ skipping 66 matching lines @@
     [button setImagePosition:NSImageRight];
     [button setTarget:self];
     [button setAction:@selector(removeAccount:)];
   }
 
   return button.autorelease();
 }
 
 @end