Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1285123002: Move Position::isRenderedCharacter() for Text node to LayoutText (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move Position::isRenderedCharacter() for Text node to LayoutText This patch moves an implementation of |Position::isRenderedCharacter()| for |Text| node to |LayoutText| to reduce usage of |InlineBox| in |Position| class for improving code health and helping identify layout API for editing. This patch is a preparation of handling of :first-letter pseudo element in selection. Following patch will move other |InlineBox| references in editing/ to layout/. BUG=174349, 518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200407

Patch Set 1 : 2015-08-12T16:31:05 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M Source/core/dom/Position.cpp View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/layout/LayoutText.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutText.cpp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-12 08:27:51 UTC) #2
yoichio
lgtm
5 years, 4 months ago (2015-08-12 08:33:19 UTC) #3
leviw_travelin_and_unemployed
lgtm
5 years, 4 months ago (2015-08-12 18:13:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285123002/1
5 years, 4 months ago (2015-08-12 18:13:42 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 18:16:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200407

Powered by Google App Engine
This is Rietveld 408576698