Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1285113002: Add opaqueredirect to ResponseType enum for Response Class (Closed)

Created:
5 years, 4 months ago by shiva.jm
Modified:
5 years, 4 months ago
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add opaqueredirect to ResponseType enum for Response Class As in spec link: https://fetch.spec.whatwg.org/#response-class, ResponseType enum should have opaqueredirect. BUG=510650, 517837 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M Source/modules/fetch/FetchResponseDataTest.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/modules/fetch/Response.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285113002/1
5 years, 4 months ago (2015-08-12 06:57:26 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 4 months ago (2015-08-12 06:57:27 UTC) #5
shiva.jm
pls have a look.
5 years, 4 months ago (2015-08-12 08:31:46 UTC) #7
hiroshige
Basically looks good. This change is related to the activities in https://codereview.chromium.org/1280733002/, so I added ...
5 years, 4 months ago (2015-08-12 09:32:28 UTC) #9
shiva.jm
updated CL description, pls have a look.
5 years, 4 months ago (2015-08-13 03:17:01 UTC) #10
horo
lgtm. Thank you. 455093 is an umbrella bug. So you should remove 455093 from BUG ...
5 years, 4 months ago (2015-08-13 03:32:48 UTC) #11
shiva.jm
On 2015/08/13 03:32:48, horo wrote: > lgtm. > Thank you. > > 455093 is an ...
5 years, 4 months ago (2015-08-13 03:34:23 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285113002/1
5 years, 4 months ago (2015-08-13 03:34:27 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-13 03:50:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285113002/1
5 years, 4 months ago (2015-08-13 04:11:42 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 04:14:17 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200460

Powered by Google App Engine
This is Rietveld 408576698