LayoutTests/editing/execCommand/insert-list-infinite-loop2.html - Issue 1285103002: [Editing] Make loop condition in insertOrderedList::doApply strict.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/insert-list-infinite-loop2.html

Issue 1285103002: [Editing] Make loop condition in insertOrderedList::doApply strict. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <script src="../../resources/testharness.js"></script>
	yosin_UTC9 2015/08/19 07:10:32 We prefer having <!DOCTYPE html> to use strict mod We prefer having <!DOCTYPE html> to use strict mode. yoichio 2015/08/20 06:31:10 Done. Show quoted text On 2015/08/19 07:10:32, Yosi_UTC9 wrote: > We prefer having <!DOCTYPE html> to use strict mode. Done.
	2 <script src="../../resources/testharnessreport.js"></script>

	3 <body contenteditable="true">
	yosin_UTC9 2015/08/19 07:10:32 Can we move contenteditable="true" to "table"? Or, Can we move contenteditable="true" to "table"? Or, move <div id="log"> and <script> out of editable element? yoichio 2015/08/20 06:31:10 Done. Show quoted text On 2015/08/19 07:10:32, Yosi_UTC9 wrote: > Can we move contenteditable="true" to "table"? > Or, move <div id="log"> and <script> out of editable element? Done.
	4 <div id="log"></div>

	5 <table><tbody><tr><td>

	6 <table ><tbody><tr><td >

	7 <ol id="ol"><li >wwwzip<br><br></li><li><br></li><li>Run<br>wine</li></ ol>

	8 </td></tr></tbody></table>

	9 Fixed Width<div style="-webkit-user-select: none;"></div><div style="display : inline-block; border:solid ; "></div>
	yosin_UTC9 2015/08/19 07:10:32 nit: we don't need to have spaces around ";". nit: we don't need to have spaces around ";". yoichio 2015/08/20 06:31:10 Done. Show quoted text On 2015/08/19 07:10:32, Yosi_UTC9 wrote: > nit: we don't need to have spaces around ";". Done.
	10 </td></tr></tbody></table>

	11 <script>

	12 test(function () {

	13 getSelection().selectAllChildren(ol);

	14 document.execCommand('insertOrderedList');

	15 });

	16 </script>

	17 </body>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/editing/commands/InsertListCommand.cpp » ('j') | no next file with comments »