Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: tests/standalone/debugger/debug_lib.dart

Issue 12851019: Fixed the first issue in debug_lib.dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/standalone/standalone.status » ('j') | tests/standalone/standalone.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/debugger/debug_lib.dart
diff --git a/tests/standalone/debugger/debug_lib.dart b/tests/standalone/debugger/debug_lib.dart
index 0d13f7aec8497c9fa937db6c40ba06586f4f4fbb..694f9c6a5677fe3b17e044ef47a98cf2e64091db 100644
--- a/tests/standalone/debugger/debug_lib.dart
+++ b/tests/standalone/debugger/debug_lib.dart
@@ -323,15 +323,7 @@ class Debugger {
bool shutdownEventSeen = false;
int isolateId = 0;
- // stdin subscription to allow terminating the test via command-line.
- var stdinSubscription;
-
Debugger(this.targetProcess, this.portNumber) {
- stdinSubscription =
- stdin.listen((d) {},
- onError: (error) => close(killDebugee: true),
- onDone: () => close(killDebugee: true));
-
var stdoutStringStream = targetProcess.stdout
.transform(new StringDecoder())
.transform(new LineTransformer());
@@ -500,7 +492,6 @@ class Debugger {
for (int i = 0; i < errors.length; i++) print(errors[i]);
}
socket.close();
- stdinSubscription.cancel();
if (killDebugee) {
targetProcess.kill();
print("Target process killed");
@@ -518,7 +509,8 @@ bool RunScript(List script) {
if (options.arguments.contains("--debuggee")) {
return false;
}
- showDebuggeeOutput = options.arguments.contains("--verbose");
+ // The default is to show debugging output.
+ showDebuggeeOutput = !options.arguments.contains("--non-verbose");
Ivan Posva 2013/03/26 15:58:38 --no-verbose
verboseWire = options.arguments.contains("--wire");
var targetOpts = [ "--debug:$debugPort" ];
@@ -531,7 +523,6 @@ bool RunScript(List script) {
process.stdin.close();
process.exitCode.then((int exitCode) {
Expect.equals(0, exitCode);
- Expect.equals(0, exitCode);
print("Debug target process exited with exit code $exitCode");
});
var debugger = new Debugger(process, debugPort);
« no previous file with comments | « no previous file | tests/standalone/standalone.status » ('j') | tests/standalone/standalone.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698