Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Issue 12851012: Add a config to use deferred image decoding on bots. (Closed)

Created:
7 years, 9 months ago by scroggo
Modified:
7 years, 4 months ago
Reviewers:
borenet, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add a config to use deferred image decoding on bots. Depends on https://codereview.appspot.com/7810045/ and a change to chrome so that our SKPs will have encoded images.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/bench_pictures.cfg View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scroggo
7 years, 9 months ago (2013-03-19 22:12:14 UTC) #1
borenet
LGTM
7 years, 9 months ago (2013-03-20 11:58:29 UTC) #2
reed1
hmmm, will this change affect our perf numbers, or only correctness tests?
7 years, 9 months ago (2013-03-20 14:35:06 UTC) #3
scroggo
On 2013/03/20 14:35:06, reed1 wrote: > hmmm, will this change affect our perf numbers, or ...
7 years, 9 months ago (2013-03-20 14:53:19 UTC) #4
scroggo
Adding a step to render_pictures requires a change in buildbot/, not trunk (Eric, please correct ...
7 years, 9 months ago (2013-03-20 14:59:37 UTC) #5
reed1
lgtm
7 years, 9 months ago (2013-03-20 15:05:24 UTC) #6
scroggo
I've finally worked out the kinks in getting us SKPs with encoded bitmaps, so this ...
7 years, 7 months ago (2013-05-14 18:30:13 UTC) #7
borenet
7 years, 7 months ago (2013-05-14 18:31:37 UTC) #8
Okay to add this one, but we should collectively determine which configs we can
drop.

Powered by Google App Engine
This is Rietveld 408576698