Issue 12851007: Revert 143825 "RenderLayer::scrollTo() should call FrameLoaderCl..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12851007: Revert 143825 "RenderLayer::scrollTo() should call FrameLoaderCl..." (Closed)

Created:
7 years, 9 months ago by abarth-chromium

Modified:
7 years, 9 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1441/

Visibility:
Public.

More Reviews

Description

Revert 143825 "RenderLayer::scrollTo() should call FrameLoaderCl..." > RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset() > https://bugs.webkit.org/show_bug.cgi?id=110673 > -and corresponding- > <rdar://problem/13258596> > > Reviewed by Sam Weinig. > > FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages that > have overflow on the body. We can easily address this by calling it at the > end of RenderLayer::scrollTo(). > > * rendering/RenderLayer.cpp: > (WebCore::RenderLayer::scrollTo): > > TBR=bdakin@apple.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146012

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	Source/WebCore/rendering/RenderLayer.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r146012.

Expand Messages | Collapse Messages