Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 1285093004: [Chromecast] Inform metrics service of not-idle state during Cast events. (Closed)

Created:
5 years, 4 months ago by gunsch
Modified:
5 years, 4 months ago
Reviewers:
gfhuang, halliwell
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Inform metrics service of not-idle state during Cast events. R=gfhuang@chromium.org,halliwell@chromium.org BUG=internal b/19094746 Committed: https://crrev.com/eb298ca8740a2ed61e64e48444edd3851a786030 Cr-Commit-Position: refs/heads/master@{#344311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chromecast/browser/metrics/cast_metrics_service_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
gunsch
5 years, 4 months ago (2015-08-19 18:32:42 UTC) #1
gfhuang
lgtm
5 years, 4 months ago (2015-08-19 18:39:23 UTC) #2
halliwell
On 2015/08/19 18:39:23, gfhuang wrote: > lgtm lgtm
5 years, 4 months ago (2015-08-19 19:46:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285093004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285093004/1
5 years, 4 months ago (2015-08-19 19:51:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 19:59:08 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 19:59:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb298ca8740a2ed61e64e48444edd3851a786030
Cr-Commit-Position: refs/heads/master@{#344311}

Powered by Google App Engine
This is Rietveld 408576698