chrome/test/data/banners/manifest.json - Issue 1285063003: manifest: rework icon selector to include small icon cut-off

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/banners/manifest.json

Issue 1285063003: manifest: rework icon selector to include small icon cut-off (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix final comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/banners/manifest.json

diff --git a/chrome/test/data/banners/manifest.json b/chrome/test/data/banners/manifest.json

index cafff5bb4d3a1e821bf7e701f716e9232f50c92f..89429dc9057aef9204ef5b36a943692cfa2577c4 100644

--- a/chrome/test/data/banners/manifest.json

+++ b/chrome/test/data/banners/manifest.json

@@ -4,26 +4,27 @@

{

"src": "launcher-icon-1x.png",

"sizes": "48x48",

- "type": "image/png",

- "density": 1.0

+ "type": "image/png"

{

"src": "launcher-icon-1-5x.png",

"sizes": "72x72",

- "type": "image/png",

- "density": 1.5

+ "type": "image/png"

{

"src": "launcher-icon-2x.png",

"sizes": "96x96",

- "type": "image/png",

- "density": 2.0

+ "type": "image/png"

{

"src": "launcher-icon-3x.png",

"sizes": "144x144",

- "type": "image/png",

- "density": 3.0

+ "type": "image/png"

+ },

+ {

+ "src": "launcher-icon-4x.png",

+ "sizes": "192x192",

+ "type": "image/png"

}

"start_url": "manifest_test_page.html",

« no previous file with comments | « chrome/test/data/banners/launcher-icon-4x.png ('k') | chrome/test/data/banners/manifest_no_type.json » ('j') | no next file with comments »