chrome/test/data/banners/manifest_no_type.json - Issue 1285063003: manifest: rework icon selector to include small icon cut-off

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/banners/manifest_no_type.json

Issue 1285063003: manifest: rework icon selector to include small icon cut-off (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix final comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "name": "Manifest test app with no type in icons",	2 "name": "Manifest test app with no type in icons",

3 "icons": [	3 "icons": [

4 {	4 {

5 "src": "launcher-icon-1x.png",	5 "src": "launcher-icon-1x.png",

6 "sizes": "48x48",	6 "sizes": "48x48"

7 "density": 1.0

8 },	7 },

9 {	8 {

10 "src": "launcher-icon-1-5x.png",	9 "src": "launcher-icon-1-5x.png",

11 "sizes": "72x72",	10 "sizes": "72x72"

12 "density": 1.5

13 },	11 },

14 {	12 {

15 "src": "launcher-icon-2x.png",	13 "src": "launcher-icon-2x.png",

16 "sizes": "96x96",	14 "sizes": "96x96"

17 "density": 2.0

18 },	15 },

19 {	16 {

20 "src": "launcher-icon-3x.png",	17 "src": "launcher-icon-3x.png",

21 "sizes": "144x144",	18 "sizes": "144x144"

22 "density": 3.0	19 },

	20 {

	21 "src": "launcher-icon-4x.png",

	22 "sizes": "192x192"

23 }	23 }

24 ],	24 ],

25 "start_url": "manifest_no_type_test_page.html",	25 "start_url": "manifest_no_type_test_page.html",

26 "display": "standalone",	26 "display": "standalone",

27 "orientation": "landscape"	27 "orientation": "landscape"

28 }	28 }

OLD	NEW

« no previous file with comments | « chrome/test/data/banners/manifest.json ('k') | chrome/test/data/banners/manifest_no_type_caps.json » ('j') | no next file with comments »