chrome/test/data/banners/manifest.json - Issue 1285063003: manifest: rework icon selector to include small icon cut-off

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/banners/manifest.json

Issue 1285063003: manifest: rework icon selector to include small icon cut-off (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comments on review Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/manifest/manifest_icon_selector_unittest.cc ('K') | « chrome/test/data/banners/launcher-icon-4x.png ('k') | chrome/test/data/banners/manifest_no_type.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "name": "Manifest test app",	2 "name": "Manifest test app",

3 "icons": [	3 "icons": [

4 {	4 {

5 "src": "launcher-icon-1x.png",	5 "src": "launcher-icon-1x.png",

6 "sizes": "48x48",	6 "sizes": "48x48",

7 "type": "image/png",	7 "type": "image/png"

8 "density": 1.0

9 },	8 },

10 {	9 {

11 "src": "launcher-icon-1-5x.png",	10 "src": "launcher-icon-1-5x.png",

12 "sizes": "72x72",	11 "sizes": "72x72",

13 "type": "image/png",	12 "type": "image/png"

14 "density": 1.5

15 },	13 },

16 {	14 {

17 "src": "launcher-icon-2x.png",	15 "src": "launcher-icon-2x.png",

18 "sizes": "96x96",	16 "sizes": "96x96",

19 "type": "image/png",	17 "type": "image/png"

20 "density": 2.0

21 },	18 },

22 {	19 {

23 "src": "launcher-icon-3x.png",	20 "src": "launcher-icon-3x.png",

24 "sizes": "144x144",	21 "sizes": "144x144",

25 "type": "image/png",	22 "type": "image/png"

26 "density": 3.0	23 },

	24 {

	25 "src": "launcher-icon-4x.png",

	26 "sizes": "192x192",

	27 "type": "image/png"

27 }	28 }

28 ],	29 ],

29 "start_url": "manifest_test_page.html",	30 "start_url": "manifest_test_page.html",

30 "display": "standalone",	31 "display": "standalone",

31 "orientation": "landscape"	32 "orientation": "landscape"

32 }	33 }

OLD	NEW