net/url_request/url_request_http_job.cc - Issue 1284993005: Notify NetworkDelegate when bytes have been received over the network.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_http_job.cc

Issue 1284993005: Notify NetworkDelegate when bytes have been received over the network. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed NetworkDelegate::OnRawBytesRead Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/url_request/url_request_context_builder.cc ('k') | net/url_request/url_request_http_job_unittest.cc » ('j') | net/url_request/url_request_http_job_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_http_job.cc

diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc

index c9aa4cc2ed326c6518658e1a01917401f97711cf..5f4f0961da1f41900631d6b76b7fce7af3aaf3fa 100644

--- a/net/url_request/url_request_http_job.cc

+++ b/net/url_request/url_request_http_job.cc

@@ -1541,6 +1541,9 @@ void URLRequestHttpJob::DoneWithRequest(CompletionCause reason) {

network_quality_estimator->NotifyRequestCompleted(*request());

}

+ // Notify about any new network usage.

+ MaybeNotifyNetworkBytes();

mmenke 2015/08/19 15:48:41 Why is this needed, when we call this in NotifyDon

sclittle 2015/08/20 01:10:49 This notification is no longer needed now that URL

RecordPerfHistograms(reason);

if (request_)

request_->set_received_response_content_length(prefilter_bytes_read());