Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Unified Diff: net/base/layered_network_delegate_unittest.cc

Issue 1284993005: Notify NetworkDelegate when bytes have been received over the network. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed empty cronet OnRawBytesRead implementation Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/layered_network_delegate.cc ('k') | net/base/network_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/layered_network_delegate_unittest.cc
diff --git a/net/base/layered_network_delegate_unittest.cc b/net/base/layered_network_delegate_unittest.cc
index 9cb77fab10002e3abd5a01151a75f12a4738707c..a74a2b6556c1ac596518a70367e6092a1a1fcf16 100644
--- a/net/base/layered_network_delegate_unittest.cc
+++ b/net/base/layered_network_delegate_unittest.cc
@@ -93,8 +93,9 @@ class TestNetworkDelegateImpl : public NetworkDelegateImpl {
IncrementAndCompareCounter("on_response_started_count");
}
- void OnRawBytesRead(const URLRequest& request, int bytes_read) override {
- IncrementAndCompareCounter("on_raw_bytes_read_count");
+ void OnNetworkBytesReceived(const URLRequest& request,
+ int64_t bytes_received) override {
+ IncrementAndCompareCounter("on_network_bytes_received_count");
}
void OnCompleted(URLRequest* request, bool started) override {
@@ -199,7 +200,7 @@ class TestLayeredNetworkDelegate : public LayeredNetworkDelegate {
EXPECT_EQ(OK, OnHeadersReceived(NULL, completion_callback.callback(),
response_headers.get(), NULL, NULL));
OnResponseStarted(request.get());
- OnRawBytesRead(*request, 0);
+ OnNetworkBytesReceived(*request, 42);
OnCompleted(request.get(), false);
OnURLRequestDestroyed(request.get());
OnPACScriptError(0, base::string16());
@@ -277,10 +278,10 @@ class TestLayeredNetworkDelegate : public LayeredNetworkDelegate {
EXPECT_EQ(1, (*counters_)["on_response_started_count"]);
}
- void OnRawBytesReadInternal(const URLRequest& request,
- int bytes_read) override {
- ++(*counters_)["on_raw_bytes_read_count"];
- EXPECT_EQ(1, (*counters_)["on_raw_bytes_read_count"]);
+ void OnNetworkBytesReceivedInternal(const URLRequest& request,
+ int64_t bytes_received) override {
+ ++(*counters_)["on_network_bytes_received_count"];
+ EXPECT_EQ(1, (*counters_)["on_network_bytes_received_count"]);
}
void OnCompletedInternal(URLRequest* request, bool started) override {
« no previous file with comments | « net/base/layered_network_delegate.cc ('k') | net/base/network_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698