Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: net/url_request/url_request_http_job_unittest.cc

Issue 1284993005: Notify NetworkDelegate when bytes have been received over the network. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job_unittest.cc
diff --git a/net/url_request/url_request_http_job_unittest.cc b/net/url_request/url_request_http_job_unittest.cc
index 96e82bf6ae46c830a13f36e5dbee293f765e98a1..cc4ca916a7b9c525c95094b4f4ed8366eb8e2aa1 100644
--- a/net/url_request/url_request_http_job_unittest.cc
+++ b/net/url_request/url_request_http_job_unittest.cc
@@ -133,6 +133,7 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
EXPECT_TRUE(request->status().is_success());
EXPECT_EQ(12, request->received_response_content_length());
+ EXPECT_EQ(51, network_delegate_.total_network_bytes_received());
}
TEST_F(URLRequestHttpJobWithMockSocketsTest, TestContentLengthAbortedRequest) {
@@ -156,6 +157,7 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest, TestContentLengthAbortedRequest) {
EXPECT_EQ(URLRequestStatus::FAILED, request->status().status());
EXPECT_EQ(12, request->received_response_content_length());
+ EXPECT_EQ(51, network_delegate_.total_network_bytes_received());
}
TEST_F(URLRequestHttpJobWithMockSocketsTest,
@@ -174,13 +176,63 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
&delegate)
.Pass();
+ delegate.set_cancel_in_received_data(true);
request->Start();
base::RunLoop().RunUntilIdle();
- request->Cancel();
- base::RunLoop().Run();
EXPECT_EQ(URLRequestStatus::CANCELED, request->status().status());
EXPECT_EQ(12, request->received_response_content_length());
+ EXPECT_EQ(51, network_delegate_.total_network_bytes_received());
+}
+
+TEST_F(URLRequestHttpJobWithMockSocketsTest,
+ TestNetworkBytesRedirectedRequest) {
+ MockRead redirect_read(
+ "HTTP/1.1 302 Found\r\n"
+ "Location: http://www.example.com\r\n\r\n");
+ StaticSocketDataProvider redirect_socket_data(&redirect_read, 1, nullptr, 0);
+ socket_factory_.AddSocketDataProvider(&redirect_socket_data);
+
+ MockRead response_reads[] = {MockRead("HTTP/1.1 200 OK\r\n"
+ "Content-Length: 12\r\n\r\n"),
+ MockRead("Test Content")};
+ StaticSocketDataProvider response_socket_data(
+ response_reads, arraysize(response_reads), nullptr, 0);
+ socket_factory_.AddSocketDataProvider(&response_socket_data);
+
+ TestDelegate delegate;
+ scoped_ptr<URLRequest> request =
+ context_->CreateRequest(GURL("http://www.redirect.com"), DEFAULT_PRIORITY,
+ &delegate)
+ .Pass();
+
+ request->Start();
+ ASSERT_TRUE(request->is_pending());
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_TRUE(request->status().is_success());
+ EXPECT_EQ(12, request->received_response_content_length());
+ EXPECT_EQ(107, network_delegate_.total_network_bytes_received());
+}
+
+TEST_F(URLRequestHttpJobWithMockSocketsTest,
+ TestNetworkBytesCancelledAfterHeaders) {
+ MockRead read("HTTP/1.1 200 OK\r\n\r\n");
+ StaticSocketDataProvider socket_data(&read, 1, nullptr, 0);
+ socket_factory_.AddSocketDataProvider(&socket_data);
+
+ TestDelegate delegate;
+ scoped_ptr<URLRequest> request =
+ context_->CreateRequest(GURL("http://www.example.com"), DEFAULT_PRIORITY,
+ &delegate)
+ .Pass();
+
+ delegate.set_cancel_in_response_started(true);
+ request->Start();
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(URLRequestStatus::CANCELED, request->status().status());
+ EXPECT_EQ(19, network_delegate_.total_network_bytes_received());
}
TEST_F(URLRequestHttpJobWithMockSocketsTest, BackoffHeader) {

Powered by Google App Engine
This is Rietveld 408576698