Notify NetworkDelegate when bytes have been received over the network.

net/url_request/url_request_http_job_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include <cstddef>
 
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
@@ skipping 115 matching lines @@
       context_->CreateRequest(GURL("http://www.example.com"), DEFAULT_PRIORITY,
                               &delegate)
           .Pass();
 
   request->Start();
   ASSERT_TRUE(request->is_pending());
   base::RunLoop().Run();
 
   EXPECT_TRUE(request->status().is_success());
   EXPECT_EQ(12, request->received_response_content_length());
+  EXPECT_GE(network_delegate_.total_network_bytes_received(),
+            reads[0].data_len + reads[1].data_len);

[mmenke, 2015/08/19 15:48:41]

We should be able to do EXPECT_EQ in these.

[sclittle, 2015/08/20 01:10:49]

Done.

 }
 
 TEST_F(URLRequestHttpJobWithMockSocketsTest, TestContentLengthAbortedRequest) {
   MockRead reads[] = {MockRead("HTTP/1.1 200 OK\r\n"
                                "Content-Length: 20\r\n\r\n"),
                       MockRead("Test Content"),
                       MockRead(net::SYNCHRONOUS, net::ERR_FAILED)};
 
   StaticSocketDataProvider socket_data(reads, arraysize(reads), nullptr, 0);
   socket_factory_.AddSocketDataProvider(&socket_data);
 
   TestDelegate delegate;
   scoped_ptr<URLRequest> request =
       context_->CreateRequest(GURL("http://www.example.com"), DEFAULT_PRIORITY,
                               &delegate)
           .Pass();
 
   request->Start();
   ASSERT_TRUE(request->is_pending());
   base::RunLoop().Run();
 
   EXPECT_EQ(URLRequestStatus::FAILED, request->status().status());
   EXPECT_EQ(12, request->received_response_content_length());
+  EXPECT_GE(network_delegate_.total_network_bytes_received(),
+            reads[0].data_len + reads[1].data_len);
 }
 
 TEST_F(URLRequestHttpJobWithMockSocketsTest,
        TestContentLengthCancelledRequest) {
   MockRead reads[] = {MockRead("HTTP/1.1 200 OK\r\n"
                                "Content-Length: 20\r\n\r\n"),
                       MockRead("Test Content"),
                       MockRead(net::SYNCHRONOUS, net::ERR_IO_PENDING)};
 
   StaticSocketDataProvider socket_data(reads, arraysize(reads), nullptr, 0);
   socket_factory_.AddSocketDataProvider(&socket_data);
 
   TestDelegate delegate;
   scoped_ptr<URLRequest> request =
       context_->CreateRequest(GURL("http://www.example.com"), DEFAULT_PRIORITY,
                               &delegate)
           .Pass();
 
+  delegate.set_cancel_in_received_data(true);
+  request->Start();
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_EQ(URLRequestStatus::CANCELED, request->status().status());
+  EXPECT_EQ(12, request->received_response_content_length());
+  EXPECT_GE(network_delegate_.total_network_bytes_received(),
+            reads[0].data_len + reads[1].data_len);
+}
+
+TEST_F(URLRequestHttpJobWithMockSocketsTest,
+       TestNetworkBytesRedirectedRequest) {
+  MockRead redirect_read(
+      "HTTP/1.1 302 Found\r\n"
+      "Location: http://www.example.com\r\n\r\n");
+  StaticSocketDataProvider redirect_socket_data(&redirect_read, 1, nullptr, 0);
+  socket_factory_.AddSocketDataProvider(&redirect_socket_data);
+
+  MockRead response_reads[] = {MockRead("HTTP/1.1 200 OK\r\n"
+                                        "Content-Length: 12\r\n\r\n"),
+                               MockRead("Test Content")};
+  StaticSocketDataProvider response_socket_data(
+      response_reads, arraysize(response_reads), nullptr, 0);
+  socket_factory_.AddSocketDataProvider(&response_socket_data);
+
+  TestDelegate delegate;
+  scoped_ptr<URLRequest> request =
+      context_->CreateRequest(GURL("http://www.redirect.com"), DEFAULT_PRIORITY,
+                              &delegate)
+          .Pass();
+
   request->Start();
+  ASSERT_TRUE(request->is_pending());
   base::RunLoop().RunUntilIdle();
-  request->Cancel();
-  base::RunLoop().Run();
+
+  EXPECT_TRUE(request->status().is_success());
+  EXPECT_EQ(12, request->received_response_content_length());
+  EXPECT_GE(network_delegate_.total_network_bytes_received(),
+            redirect_read.data_len + response_reads[0].data_len +
+                response_reads[1].data_len);
+}
+
+TEST_F(URLRequestHttpJobWithMockSocketsTest,
+       TestNetworkBytesCancelledAfterHeaders) {

[mmenke, 2015/08/19 15:48:41]

Maybe an HTTP/0.9 one, too?

[mmenke, 2015/08/19 15:48:41]

Maybe just a simple sanity test - start a request, cancel it, and make sure
nothing was received?  Just need to add a socket data provider with an
asynchronous connect, and no reads.

[sclittle, 2015/08/20 01:10:49]

Done.

[sclittle, 2015/08/20 01:10:49]

Done.

+  MockRead read("HTTP/1.1 200 OK\r\n\r\n");
+  StaticSocketDataProvider socket_data(&read, 1, nullptr, 0);
+  socket_factory_.AddSocketDataProvider(&socket_data);
+
+  TestDelegate delegate;
+  scoped_ptr<URLRequest> request =
+      context_->CreateRequest(GURL("http://www.example.com"), DEFAULT_PRIORITY,
+                              &delegate)
+          .Pass();
+
+  delegate.set_cancel_in_response_started(true);
+  request->Start();
+  base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(URLRequestStatus::CANCELED, request->status().status());
-  EXPECT_EQ(12, request->received_response_content_length());
+  EXPECT_GE(network_delegate_.total_network_bytes_received(), read.data_len);
 }
 
 TEST_F(URLRequestHttpJobWithMockSocketsTest, BackoffHeader) {
   MockWrite writes[] = {MockWrite(
       "GET / HTTP/1.1\r\n"
       "Host: www.example.com\r\n"
       "Connection: keep-alive\r\n"
       "User-Agent:\r\n"
       "Accept-Encoding: gzip, deflate\r\n"
       "Accept-Language: en-us,fr\r\n\r\n")};
@@ skipping 378 matching lines @@
   req_->SetLoadFlags(LOAD_DISABLE_CACHE);
   job->Start();
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(URLRequestStatus::IO_PENDING, req_->status().status());
   EXPECT_TRUE(fake_handshake_stream->initialize_stream_was_called());
 }
 
 }  // namespace
 
 }  // namespace net