Notify NetworkDelegate when bytes have been received over the network.

net/base/network_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NETWORK_DELEGATE_H_
 #define NET_BASE_NETWORK_DELEGATE_H_
 
+#include <stdint.h>
 #include <string>
 
 #include "base/callback.h"
 #include "base/strings/string16.h"
 #include "base/threading/non_thread_safe.h"
 #include "net/base/auth.h"
 #include "net/base/completion_callback.h"
 #include "net/cookies/canonical_cookie.h"
 
 class GURL;
@@ skipping 61 matching lines @@
   int NotifyHeadersReceived(
       URLRequest* request,
       const CompletionCallback& callback,
       const HttpResponseHeaders* original_response_headers,
       scoped_refptr<HttpResponseHeaders>* override_response_headers,
       GURL* allowed_unsafe_redirect_url);
   void NotifyBeforeRedirect(URLRequest* request,
                             const GURL& new_location);
   void NotifyResponseStarted(URLRequest* request);
   void NotifyRawBytesRead(const URLRequest& request, int bytes_read);
+  void NotifyNetworkBytesReceived(const URLRequest& request, int64 bytes_read);

[tbansal1, 2015/08/17 20:51:17]

|bytes_read| or |bytes_received|? I believe you are using both.

[bengr, 2015/08/17 21:30:39]

FWIW, I like "received" and "sent".

[sclittle, 2015/08/17 23:35:13]

Changed to bytes_received.

   void NotifyCompleted(URLRequest* request, bool started);
   void NotifyURLRequestDestroyed(URLRequest* request);
   void NotifyPACScriptError(int line_number, const base::string16& error);
   AuthRequiredResponse NotifyAuthRequired(URLRequest* request,
                                           const AuthChallengeInfo& auth_info,
                                           const AuthCallback& callback,
                                           AuthCredentials* credentials);
   bool CanGetCookies(const URLRequest& request,
                      const CookieList& cookie_list);
   bool CanSetCookie(const URLRequest& request,
@@ skipping 95 matching lines @@
   // request.
   virtual void OnBeforeRedirect(URLRequest* request,
                                 const GURL& new_location) = 0;
 
   // This corresponds to URLRequestDelegate::OnResponseStarted.
   virtual void OnResponseStarted(URLRequest* request) = 0;
 
   // Called every time we read raw bytes.
   virtual void OnRawBytesRead(const URLRequest& request, int bytes_read) = 0;
 
+  // Called when bytes are received from the network, such as after receiving

[tbansal1, 2015/08/17 20:51:17]

Would this also get triggered on requests that are served by localhost or by
cache?

[sclittle, 2015/08/17 23:35:13]

I've added a comment here. Right now, this would include localhost, but it
wouldn't include cached response bytes that didn't come over any network.

+  // headers or reading raw response bytes. |bytes_received| is the number of
+  // bytes measured at the application layer that have been received over the

[bengr, 2015/08/17 21:30:39]

It's work some more comment space to be ultra specific about what this includes.
E.g., currently, TLS overhead is not included.

[sclittle, 2015/08/17 23:35:13]

I've added some more detail here, but I'm not exactly sure what is and isn't
included in URLRequest::GetTotalReceivedBytes.

+  // network since the last time OnNetworkBytesReceived was called.
+  // |bytes_received| will always be greater than 0.
+  virtual void OnNetworkBytesReceived(const URLRequest& request,
+                                      int64 bytes_received) = 0;
+
   // Indicates that the URL request has been completed or failed.
   // |started| indicates whether the request has been started. If false,
   // some information like the socket address is not available.
   virtual void OnCompleted(URLRequest* request, bool started) = 0;
 
   // Called when an URLRequest is being destroyed. Note that the request is
   // being deleted, so it's not safe to call any methods that may result in
   // a virtual method call.
   virtual void OnURLRequestDestroyed(URLRequest* request) = 0;
 
@@ skipping 64 matching lines @@
   // header is stripped from the request.
   virtual bool OnCancelURLRequestWithPolicyViolatingReferrerHeader(
       const URLRequest& request,
       const GURL& target_url,
       const GURL& referrer_url) const = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_NETWORK_DELEGATE_H_