Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1284993004: Add a short term solution to fix OSX 10.11 system font rendering problems. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a short term solution to fix OSX 10.11 system font rendering problems. I landed a CL (https://codereview.chromium.org/1276003003/) which fixes system font problems on OSX 10.9 and OSX 10.10. The CL also fixed MatchNSFontFamily() to correctly return the system font on 10.11, but this causes glyph rendering problems. In the short term, I'm adding logic to MatchNSFontFamily() to return nil on 10.11, which was the original behavior before I landed that CL. BUG=521034 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200618

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M Source/platform/fonts/mac/FontFamilyMatcherMac.mm View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/platform/mac/VersionUtilMac.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/mac/VersionUtilMac.mm View 2 chunks +9 lines, -0 lines 1 comment Download

Messages

Total messages: 18 (6 generated)
erikchen
https://codereview.chromium.org/1284993004/diff/20001/Source/platform/mac/VersionUtilMac.mm File Source/platform/mac/VersionUtilMac.mm (right): https://codereview.chromium.org/1284993004/diff/20001/Source/platform/mac/VersionUtilMac.mm#newcode30 Source/platform/mac/VersionUtilMac.mm:30: bool IsOSYosemiteOrEarlier() Ideally, I would make a function called ...
5 years, 4 months ago (2015-08-15 01:31:57 UTC) #1
erikchen
On 2015/08/15 01:31:57, erikchen wrote: > https://codereview.chromium.org/1284993004/diff/20001/Source/platform/mac/VersionUtilMac.mm > File Source/platform/mac/VersionUtilMac.mm (right): > > https://codereview.chromium.org/1284993004/diff/20001/Source/platform/mac/VersionUtilMac.mm#newcode30 > ...
5 years, 4 months ago (2015-08-15 01:34:55 UTC) #2
erikchen
tkent or keishi: Please review.
5 years, 4 months ago (2015-08-15 01:35:35 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284993004/20001
5 years, 4 months ago (2015-08-15 01:35:58 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-15 03:10:33 UTC) #8
keishi
lgtm
5 years, 4 months ago (2015-08-15 04:16:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284993004/20001
5 years, 4 months ago (2015-08-15 04:25:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/88618)
5 years, 4 months ago (2015-08-15 04:33:14 UTC) #13
tkent
lgtm
5 years, 4 months ago (2015-08-17 00:11:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284993004/20001
5 years, 4 months ago (2015-08-17 00:11:50 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200618
5 years, 4 months ago (2015-08-17 00:58:25 UTC) #17
yurys
5 years, 4 months ago (2015-08-17 15:41:17 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1296243002/ by yurys@chromium.org.

The reason for reverting is: Newly added test has been failing since its
introduction

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=....

Powered by Google App Engine
This is Rietveld 408576698