Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 1284853003: Respect old generation limit in large object space allocations. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Respect old generation limit in large object space allocations. Also remove unused max_capcity_ field in old spaces. BUG=chromium:518028, chromium:504854 LOG=n Committed: https://crrev.com/debf58cd55aca24754876630b170c9cbaff36caa Cr-Commit-Position: refs/heads/master@{#30114}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -38 lines) Patch
M src/heap/heap.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/heap/spaces.h View 1 2 7 chunks +10 lines, -18 lines 0 comments Download
M src/heap/spaces.cc View 2 3 5 chunks +3 lines, -10 lines 0 comments Download
M test/cctest/test-spaces.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-11 07:11:06 UTC) #2
Michael Lippautz
lgtm
5 years, 4 months ago (2015-08-11 07:22:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284853003/20001
5 years, 4 months ago (2015-08-11 07:29:20 UTC) #5
Michael Starzinger
LGTM with nits. https://codereview.chromium.org/1284853003/diff/20001/src/heap/spaces.h File src/heap/spaces.h (left): https://codereview.chromium.org/1284853003/diff/20001/src/heap/spaces.h#oldcode2655 src/heap/spaces.h:2655: // Creates an old space object ...
5 years, 4 months ago (2015-08-11 07:42:36 UTC) #7
Hannes Payer (out of office)
https://codereview.chromium.org/1284853003/diff/20001/src/heap/spaces.h File src/heap/spaces.h (left): https://codereview.chromium.org/1284853003/diff/20001/src/heap/spaces.h#oldcode2655 src/heap/spaces.h:2655: // Creates an old space object with a given ...
5 years, 4 months ago (2015-08-11 08:04:40 UTC) #8
Hannes Payer (out of office)
https://codereview.chromium.org/1284853003/diff/40001/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/1284853003/diff/40001/src/heap/spaces.cc#newcode2848 src/heap/spaces.cc:2848: heap()->incremental_marking()->IsStopped() && We cannot allow incremental marking to go ...
5 years, 4 months ago (2015-08-11 11:20:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284853003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284853003/60001
5 years, 4 months ago (2015-08-11 14:49:58 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-11 14:52:01 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 14:52:08 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/debf58cd55aca24754876630b170c9cbaff36caa
Cr-Commit-Position: refs/heads/master@{#30114}

Powered by Google App Engine
This is Rietveld 408576698