pdf/out_of_process_instance.cc - Issue 1284833004: Remove remaining legacy SplitString calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/out_of_process_instance.cc

Issue 1284833004: Remove remaining legacy SplitString calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/out_of_process_instance.cc

diff --git a/pdf/out_of_process_instance.cc b/pdf/out_of_process_instance.cc

index 1d782beb1b104c498a2dab0b4fb6869ed57e6f99..705da85ab7d9bf424d5a2a23b06568420d3c7405 100644

--- a/pdf/out_of_process_instance.cc

+++ b/pdf/out_of_process_instance.cc

@@ -206,8 +206,9 @@ const PPP_Pdf ppp_private = {

int ExtractPrintPreviewPageIndex(const std::string& src_url) {

// Sample |src_url| format: chrome://print/id/page_index/print.pdf

- std::vector<std::string> url_substr;

- base::SplitString(src_url.substr(strlen(kChromePrint)), '/', &url_substr);

+ std::vector<std::string> url_substr = base::SplitString(

+ src_url.substr(strlen(kChromePrint)), "/",

+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

if (url_substr.size() != 3)

return -1;