Remove remaining legacy SplitString calls.

chromeos/network/network_change_notifier_chromeos_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_change_notifier_chromeos.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 109 matching lines @@
  protected:
   NetworkChangeNotifierChromeosUpdateTest() : default_network_("") {
   }
   ~NetworkChangeNotifierChromeosUpdateTest() override {}
 
   void SetNotifierState(const NotifierState& notifier_state) {
     notifier_.connection_type_ = notifier_state.type;
     notifier_.service_path_ = notifier_state.service_path;
     notifier_.ip_address_ = notifier_state.ip_address;
     notifier_.max_bandwidth_mbps_ = notifier_state.max_bandwidth;
-    std::vector<std::string> dns_servers;
-    base::SplitString(notifier_state.dns_servers, ',', &dns_servers);
+    std::vector<std::string> dns_servers =
+        base::SplitString(notifier_state.dns_servers, ",",
+                          base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
     notifier_.dns_servers_ = dns_servers;
   }
 
   void VerifyNotifierState(const NotifierState& notifier_state) {
     EXPECT_EQ(notifier_state.type, notifier_.connection_type_);
     EXPECT_EQ(notifier_state.service_path, notifier_.service_path_);
     EXPECT_EQ(notifier_state.ip_address, notifier_.ip_address_);
     EXPECT_EQ(notifier_state.max_bandwidth, notifier_.max_bandwidth_mbps_);
-    std::vector<std::string> dns_servers;
-    base::SplitString(notifier_state.dns_servers, ',', &dns_servers);
+    std::vector<std::string> dns_servers =
+        base::SplitString(notifier_state.dns_servers, ",",
+                          base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
     EXPECT_EQ(dns_servers, notifier_.dns_servers_);
   }
 
   // Sets the default network state used for notifier updates.
   void SetDefaultNetworkState(
       const DefaultNetworkState& default_network_state) {
     default_network_.visible_ = true;
     if (default_network_state.is_connected)
       default_network_.connection_state_ = shill::kStateOnline;
     else
       default_network_.connection_state_ = shill::kStateConfiguration;
     default_network_.type_ = default_network_state.type;
     default_network_.network_technology_ =
         default_network_state.network_technology;
     default_network_.path_ = default_network_state.service_path;
     default_network_.ip_address_ = default_network_state.ip_address;
-    std::vector<std::string> dns_servers;
-    base::SplitString(default_network_state.dns_servers, ',', &dns_servers);
+    std::vector<std::string> dns_servers =
+        base::SplitString(default_network_state.dns_servers, ",",
+                          base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
     default_network_.dns_servers_ = dns_servers;
   }
 
   // Process an default network update based on the state of |default_network_|.
   void ProcessDefaultNetworkUpdate(bool* type_changed,
                                    bool* ip_changed,
                                    bool* dns_changed,
                                    bool* max_bandwidth_changed) {
     notifier_.UpdateState(&default_network_, type_changed, ip_changed,
                           dns_changed, max_bandwidth_changed);
@@ skipping 189 matching lines @@
     VerifyNotifierState(test_cases[i].expected_state);
     EXPECT_EQ(test_cases[i].expected_type_changed, type_changed);
     EXPECT_EQ(test_cases[i].expected_ip_changed, ip_changed);
     EXPECT_EQ(test_cases[i].expected_dns_changed, dns_changed);
     EXPECT_EQ(test_cases[i].expected_max_bandwidth_changed,
               max_bandwidth_changed);
   }
 }
 
 }  // namespace chromeos