Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 128483002: Roll gyp 1830:1831 (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Roll gyp 1830:1831 1831 - Don't try to match mixed source/dir gyp order on MSVS prior to 2010 BUG=none LOG=n R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M Makefile View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-08 15:48:34 UTC) #1
Michael Achenbach
On 2014/01/08 15:48:34, jochen wrote: lgtm
6 years, 11 months ago (2014-01-08 15:54:02 UTC) #2
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-08 15:54:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18498 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698