chrome/test/chromedriver/embed_user_data_dir_in_cpp.py - Issue 12848005: [chromedriver] Separate stuff of chrome from chromedriver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/embed_user_data_dir_in_cpp.py

Issue 12848005: [chromedriver] Separate stuff of chrome from chromedriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments and fix compile error on mac. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/embed_user_data_dir_in_cpp.py

diff --git a/chrome/test/chromedriver/embed_user_data_dir_in_cpp.py b/chrome/test/chromedriver/embed_user_data_dir_in_cpp.py

index 51080f74d520346220de3b53d5d4dd454a2751d4..46b32f5e560e77dc7d248973197b5375a051aa30 100755

--- a/chrome/test/chromedriver/embed_user_data_dir_in_cpp.py

+++ b/chrome/test/chromedriver/embed_user_data_dir_in_cpp.py

@@ -27,7 +27,7 @@ def main():

contents = f.read()

global_string_map[var_name] = contents

- cpp_source.WriteSource('user_data_dir', 'chrome/test/chromedriver',

+ cpp_source.WriteSource('user_data_dir', 'chrome/test/chromedriver/chrome',

options.directory, global_string_map)