chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java - Issue 1284743003: Add referrer through service connection in custom tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java

Issue 1284743003: Add referrer through service connection in custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java

index 439e90691a6bece003bec392e4f761cce3087e81..53312f14b1332038f4fc0bcbc76dc6f4cfca5aea 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java

@@ -154,8 +154,9 @@ public class CustomTab extends ChromeTab {

private final boolean mEnableUrlBarHiding;

/**

- * Construct an CustomTab. It might load a prerendered {@link WebContents} for the URL, if

- * {@link CustomTabsConnectionService} has successfully warmed up for the url.

+ * Construct an CustomTab. Note that url and referrer given here is only used to retrieve a

+ * prerendered web contents if it exists. It might load a prerendered {@link WebContents} for

+ * the URL, if {@link CustomTabsConnectionService} has successfully warmed up for the url.

public CustomTab(ChromeActivity activity, WindowAndroid windowAndroid, IBinder session,

String url, String referrer, int parentTabId, boolean enableUrlBarHiding) {