Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: sync/internal_api/sync_manager_impl.cc

Issue 12847003: Separate invalidator and sync client ID (part 2/2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/sync_manager_impl.cc
diff --git a/sync/internal_api/sync_manager_impl.cc b/sync/internal_api/sync_manager_impl.cc
index 352a57ead56342d41b9743c9680f26a41bb960b1..9d53fb91f739e3cf6e27e23e1e034813dfe67ca5 100644
--- a/sync/internal_api/sync_manager_impl.cc
+++ b/sync/internal_api/sync_manager_impl.cc
@@ -340,6 +340,7 @@ void SyncManagerImpl::Init(
SyncManager::ChangeDelegate* change_delegate,
const SyncCredentials& credentials,
scoped_ptr<Invalidator> invalidator,
+ const std::string& invalidator_client_id,
const std::string& restored_key_for_bootstrapping,
const std::string& restored_keystore_key_for_bootstrapping,
scoped_ptr<InternalComponentsFactory> internal_components_factory,
@@ -417,16 +418,11 @@ void SyncManagerImpl::Init(
std::string sync_id = directory()->cache_guid();
- // TODO(rlarocque): The invalidator client ID should be independent from the
- // sync client ID. See crbug.com/124142.
- const std::string invalidator_client_id = sync_id;
-
allstatus_.SetSyncId(sync_id);
allstatus_.SetInvalidatorClientId(invalidator_client_id);
DVLOG(1) << "Setting sync client ID: " << sync_id;
DVLOG(1) << "Setting invalidator client ID: " << invalidator_client_id;
- invalidator_->SetUniqueId(invalidator_client_id);
// Build a SyncSessionContext and store the worker in it.
DVLOG(1) << "Sync is bringing up SyncSessionContext.";

Powered by Google App Engine
This is Rietveld 408576698