Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1284693002: [TextBlob] Fall back to TightRunBounds when the font bounds are empty (Closed)

Created:
5 years, 4 months ago by f(malita)
Modified:
5 years, 4 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

[TextBlob] Fall back to TightRunBounds when the font bounds are empty Empty font bounds are likely an indication of a font bug. As a best effort, we can use TightRunBounds in this easily detectable case. BUG=507022 R=reed@google.com,bungeman@google.com Committed: https://skia.googlesource.com/skia/+/d6b99cc6b84b3ec864221cbe9945d203bd9eb072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/core/SkTextBlob.cpp View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
f(malita)
5 years, 4 months ago (2015-08-10 16:06:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284693002/1
5 years, 4 months ago (2015-08-10 16:06:27 UTC) #3
reed1
Ugh, I hate that the client needed to to this.. but it makes sense to ...
5 years, 4 months ago (2015-08-10 16:08:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-10 16:21:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284693002/1
5 years, 4 months ago (2015-08-10 16:23:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d6b99cc6b84b3ec864221cbe9945d203bd9eb072
5 years, 4 months ago (2015-08-10 16:24:36 UTC) #9
egdaniel
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1283853002/ by egdaniel@google.com. ...
5 years, 4 months ago (2015-08-10 18:02:27 UTC) #10
fmalita_google_do_not_use
5 years, 4 months ago (2015-08-10 18:05:55 UTC) #11
Message was sent while issue was closed.
On 2015/08/10 18:02:27, egdaniel wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1283853002/ by mailto:egdaniel@google.com.
> 
> The reason for reverting is: Breaking DEPS roll on Assert in
> SkTextBlobBuilder::TightRunBounds..

Yup, I believe the assert is correct: TightRunBounds assumes default glyph
advances.  We'll need to do some extra work to support the other positioning
modes.

Powered by Google App Engine
This is Rietveld 408576698