Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: src/d8.cc

Issue 1284683004: [d8 Workers] Add max worker count, throw an exception if too many. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: decrease worker limit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-518748.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 5fa7c262994c77076951bf97022d00e2c0119731..246c8f038c33920b5595b3f1c979566c135ee99c 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -75,6 +75,7 @@ namespace v8 {
namespace {
const int MB = 1024 * 1024;
+const int kMaxWorkers = 50;
class ShellArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
@@ -706,6 +707,11 @@ void Shell::WorkerNew(const v8::FunctionCallbackInfo<v8::Value>& args) {
{
base::LockGuard<base::Mutex> lock_guard(workers_mutex_.Pointer());
+ if (workers_.length() >= kMaxWorkers) {
+ Throw(args.GetIsolate(), "Too many workers, I won't let you create more");
+ return;
+ }
+
// Initialize the internal field to NULL; if we return early without
// creating a new Worker (because the main thread is terminating) we can
// early-out from the instance calls.
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-518748.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698