Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1284643005: Get rid of a couple references to IDR_WARNING (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of a couple references to IDR_WARNING This changes the appearance of the chrome://extensions warning banner (for the better, IMO) This makes no difference to inspect.css because the version restriction was removed in 794befa4c5 and the css rules were dead code BUG=505953 Committed: https://crrev.com/87f6aaa3de7b4c37088421de09e68c3eb01a48d7 Cr-Commit-Position: refs/heads/master@{#342777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M chrome/browser/resources/extensions/extensions.css View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/inspect/inspect.css View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
5 years, 4 months ago (2015-08-11 01:42:35 UTC) #2
Dan Beam
lgtm
5 years, 4 months ago (2015-08-11 01:45:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284643005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284643005/1
5 years, 4 months ago (2015-08-11 01:46:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 02:43:30 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 02:44:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87f6aaa3de7b4c37088421de09e68c3eb01a48d7
Cr-Commit-Position: refs/heads/master@{#342777}

Powered by Google App Engine
This is Rietveld 408576698