Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1284633004: Add Dart_ListGetRange (Closed) Base URL: https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git@master
Patch Set: Address review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 178db2e18c05c21fbc28d464338d79ed4623afb3..ff30eaf78205a3ad8d1070c81bdce15a1b0b322a 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -2743,6 +2743,68 @@ DART_EXPORT Dart_Handle Dart_ListGetAt(Dart_Handle list, intptr_t index) {
}
+#define GET_LIST_RANGE(isolate, type, obj, offset, length) \
+ const type& array_obj = type::Cast(obj); \
+ if ((offset >= 0) && (offset + length <= array_obj.Length())) { \
+ for (intptr_t index = 0; index < length; ++index) { \
+ result[index] = Api::NewHandle(isolate, array_obj.At(index + offset)); \
+ } \
+ return Api::Success(); \
+ } \
+ return Api::NewError("Invalid offset/length passed in to access list"); \
+
+
+DART_EXPORT Dart_Handle Dart_ListGetRange(Dart_Handle list,
+ intptr_t offset,
+ intptr_t length,
+ Dart_Handle* result) {
+ Isolate* isolate = Isolate::Current();
+ DARTSCOPE(isolate);
+ if (result == NULL) {
+ RETURN_NULL_ERROR(result);
+ }
+ const Object& obj = Object::Handle(isolate, Api::UnwrapHandle(list));
+ if (obj.IsArray()) {
+ GET_LIST_RANGE(isolate, Array, obj, offset, length);
+ } else if (obj.IsGrowableObjectArray()) {
+ GET_LIST_RANGE(isolate, GrowableObjectArray, obj, offset, length);
+ } else if (obj.IsError()) {
+ return list;
+ } else {
+ CHECK_CALLBACK_STATE(isolate);
+ // Check and handle a dart object that implements the List interface.
+ const Instance& instance =
+ Instance::Handle(isolate, GetListInstance(isolate, obj));
+ if (!instance.IsNull()) {
+ const intptr_t kNumArgs = 2;
+ ArgumentsDescriptor args_desc(
+ Array::Handle(ArgumentsDescriptor::New(kNumArgs)));
+ const Function& function = Function::Handle(
+ isolate,
+ Resolver::ResolveDynamic(instance,
+ Symbols::AssignIndexToken(),
+ args_desc));
+ if (!function.IsNull()) {
+ const Array& args = Array::Handle(Array::New(kNumArgs));
+ args.SetAt(0, instance);
+ Instance& index = Instance::Handle(isolate);
+ for (intptr_t i = 0; i < length; ++i) {
+ index = Integer::New(i);
+ args.SetAt(1, index);
+ Dart_Handle value = Api::NewHandle(isolate,
+ DartEntry::InvokeFunction(function, args));
+ if (Dart_IsError(value))
+ return value;
+ result[i] = value;
+ }
+ return Api::Success();
+ }
+ }
+ return Api::NewError("Object does not implement the 'List' interface");
+ }
+}
+
+
#define SET_LIST_ELEMENT(isolate, type, obj, index, value) \
const type& array = type::Cast(obj); \
const Object& value_obj = Object::Handle(isolate, Api::UnwrapHandle(value)); \
« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698