Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Issue 128463002: Work around SkString::gEmptyRec->writable_str() is unwritable. (Closed)

Created:
6 years, 11 months ago by bungeman-skia
Modified:
6 years, 11 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Work around SkString::gEmptyRec->writable_str() is unwritable. See https://code.google.com/p/skia/issues/detail?id=1989 R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=12961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/ports/SkFontHost_win_dw.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
6 years, 11 months ago (2014-01-08 15:47:48 UTC) #1
reed1
lgtm
6 years, 11 months ago (2014-01-08 15:50:16 UTC) #2
bungeman-skia
6 years, 11 months ago (2014-01-08 15:53:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698