Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8060)

Unified Diff: chrome/common/extensions/features/feature.h

Issue 12846011: Implement API features for the Extension API feature system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed memory leak Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/features/feature.h
diff --git a/chrome/common/extensions/features/feature.h b/chrome/common/extensions/features/feature.h
index 53fa06bef270d2079d1fc49bb2976fc965043caf..748d04f9f4e2e71d33babfd9716d2fbca697eab1 100644
--- a/chrome/common/extensions/features/feature.h
+++ b/chrome/common/extensions/features/feature.h
@@ -88,6 +88,7 @@ class Feature {
const std::string message_;
};
+ Feature();
virtual ~Feature();
// Used by ChromeV8Context until the feature system is fully functional.
@@ -124,6 +125,7 @@ class Feature {
const std::string& name() const { return name_; }
void set_name(const std::string& name) { name_ = name; }
+ const std::set<std::string>& dependencies() { return dependencies_; }
// Gets the platform the code is currently running on.
static Platform GetCurrentPlatform();
@@ -131,7 +133,6 @@ class Feature {
// Gets the Feature::Location value for the specified Manifest::Location.
static Location ConvertLocation(Manifest::Location extension_location);
- // TODO(justinlin): Remove and move to APIFeature when it exists.
virtual std::set<Context>* GetContexts() = 0;
// Returns true if the feature is available to be parsed into a new extension
@@ -167,6 +168,7 @@ class Feature {
protected:
std::string name_;
+ std::set<std::string> dependencies_;
};
} // namespace extensions
« no previous file with comments | « chrome/common/extensions/features/base_feature_provider_unittest.cc ('k') | chrome/common/extensions/features/feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698