Chromium Code Reviews| Index: chrome/common/extensions/features/simple_feature.cc |
| diff --git a/chrome/common/extensions/features/simple_feature.cc b/chrome/common/extensions/features/simple_feature.cc |
| index de973400d097079d874b5e5ad51ab3fdaeb4029a..bc953dccea36a2bb014215089bb155d2f5bfb53c 100644 |
| --- a/chrome/common/extensions/features/simple_feature.cc |
| +++ b/chrome/common/extensions/features/simple_feature.cc |
| @@ -208,9 +208,10 @@ bool SimpleFeature::Equals(const SimpleFeature& other) const { |
| channel_ == other.channel_; |
| } |
| -void SimpleFeature::Parse(const DictionaryValue* value) { |
| +bool SimpleFeature::Parse(const DictionaryValue* value) { |
| ParseURLPatterns(value, "matches", &matches_); |
| ParseSet(value, "whitelist", &whitelist_); |
| + ParseSet(value, "dependencies", &dependencies_); |
| ParseEnumSet<Manifest::Type>(value, "extension_types", &extension_types_, |
| g_mappings.Get().extension_types); |
| ParseEnumSet<Context>(value, "contexts", &contexts_, |
| @@ -224,6 +225,7 @@ void SimpleFeature::Parse(const DictionaryValue* value) { |
| ParseEnum<VersionInfo::Channel>( |
| value, "channel", &channel_, |
| g_mappings.Get().channels); |
| + return true; |
|
not at google - send to devlin
2013/03/26 00:34:48
i.e. return "" here
cduvall
2013/03/26 19:24:05
Done.
|
| } |
| Feature::Availability SimpleFeature::IsAvailableToManifest( |