Implement API features for the Extension API feature system

chrome/common/extensions/features/base_feature_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/features/base_feature_provider.h"
 
+#include "chrome/common/extensions/features/permission_feature.h"
 #include "chrome/common/extensions/value_builder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using chrome::VersionInfo;
 using extensions::BaseFeatureProvider;
 using extensions::DictionaryBuilder;
 using extensions::Extension;
 using extensions::Feature;
 using extensions::ListBuilder;
 using extensions::Manifest;
+using extensions::PermissionFeature;
 using extensions::SimpleFeature;
 
 TEST(BaseFeatureProvider, ManifestFeatures) {
   BaseFeatureProvider* provider =
       BaseFeatureProvider::GetManifestFeatures();
   SimpleFeature* feature =
       static_cast<SimpleFeature*>(provider->GetFeature("description"));
   ASSERT_TRUE(feature);
   EXPECT_EQ(5u, feature->extension_types()->size());
   EXPECT_EQ(1u, feature->extension_types()->count(Manifest::TYPE_EXTENSION));
@@ skipping 66 matching lines @@
   EXPECT_EQ(Feature::NOT_FOUND_IN_WHITELIST, feature->IsAvailableToContext(
       extension.get(), Feature::UNSPECIFIED_CONTEXT).result());
 
   feature =
     static_cast<SimpleFeature*>(provider->GetFeature("clipboardWrite"));
   ASSERT_TRUE(feature);
   EXPECT_EQ(Feature::NOT_PRESENT, feature->IsAvailableToContext(
       extension.get(), Feature::UNSPECIFIED_CONTEXT).result());
 }
 
+SimpleFeature* CreatePermissionFeature() {
+  return new PermissionFeature();
+}
+
 TEST(BaseFeatureProvider, Validation) {
   scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
 
   base::DictionaryValue* feature1 = new base::DictionaryValue();
   value->Set("feature1", feature1);
 
   base::DictionaryValue* feature2 = new base::DictionaryValue();
   base::ListValue* extension_types = new base::ListValue();
   extension_types->Append(new base::StringValue("extension"));
   feature2->Set("extension_types", extension_types);
   base::ListValue* contexts = new base::ListValue();
   contexts->Append(new base::StringValue("blessed_extension"));
   feature2->Set("contexts", contexts);
   value->Set("feature2", feature2);
 
   scoped_ptr<BaseFeatureProvider> provider(
-      new BaseFeatureProvider(*value, NULL));
+      new BaseFeatureProvider(*value, CreatePermissionFeature));
 
   // feature1 won't validate because it lacks an extension type.
   EXPECT_FALSE(provider->GetFeature("feature1"));
 
   // If we add one, it works.
   feature1->Set("extension_types", extension_types->DeepCopy());
-  provider.reset(new BaseFeatureProvider(*value, NULL));
+  provider.reset(new BaseFeatureProvider(*value, CreatePermissionFeature));
   EXPECT_TRUE(provider->GetFeature("feature1"));
 
   // feature2 won't validate because of the presence of "contexts".
   EXPECT_FALSE(provider->GetFeature("feature2"));
 
   // If we remove it, it works.
   feature2->Remove("contexts", NULL);
-  provider.reset(new BaseFeatureProvider(*value, NULL));
+  provider.reset(new BaseFeatureProvider(*value, CreatePermissionFeature));
   EXPECT_TRUE(provider->GetFeature("feature2"));
 }
 
 TEST(BaseFeatureProvider, ComplexFeatures) {
   scoped_ptr<base::DictionaryValue> rule(
       DictionaryBuilder()
       .Set("feature1",
            ListBuilder().Append(DictionaryBuilder()
                                 .Set("channel", "beta")
                                 .Set("extension_types",
@@ skipping 31 matching lines @@
         Manifest::TYPE_EXTENSION,
         Feature::UNSPECIFIED_LOCATION,
         Feature::UNSPECIFIED_PLATFORM).result());
     EXPECT_NE(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
         "2",
         Manifest::TYPE_LEGACY_PACKAGED_APP,
         Feature::UNSPECIFIED_LOCATION,
         Feature::UNSPECIFIED_PLATFORM).result());
   }
 }