Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chrome/android/java/res/layout/snackbar.xml

Issue 1284493002: Make the button in snackbar larger and easier to click (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: textview -> button Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/snackbar/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/snackbar.xml
diff --git a/chrome/android/java/res/layout/snackbar.xml b/chrome/android/java/res/layout/snackbar.xml
index 41669de0be73fa0a741ff4f92c92dd110dae6117..a2b51f257c00b486af679689eb11db55d10a7237 100644
--- a/chrome/android/java/res/layout/snackbar.xml
+++ b/chrome/android/java/res/layout/snackbar.xml
@@ -8,9 +8,7 @@
android:layout_height="wrap_content"
android:background="#282C32"
android:minHeight="@dimen/snackbar_min_height"
- android:orientation="horizontal"
- android:paddingTop="14dp"
- android:paddingBottom="14dp" >
+ android:orientation="horizontal" >
<org.chromium.chrome.browser.snackbar.TemplatePreservingTextView
android:id="@+id/snackbar_message"
@@ -18,19 +16,21 @@
android:layout_height="wrap_content"
android:layout_gravity="start|center_vertical"
android:layout_marginStart="24dp"
+ android:layout_marginTop="14dp"
+ android:layout_marginBottom="14dp"
android:layout_weight="1"
android:textAlignment="viewStart"
android:textColor="@android:color/white"
android:textSize="14sp" />
- <TextView
+ <Button
android:id="@+id/snackbar_button"
android:layout_width="wrap_content"
- android:layout_height="match_parent"
- android:fontFamily="sans-serif-medium"
- android:gravity="center_vertical"
+ android:layout_height="@dimen/snackbar_min_height"
+ android:background="#282C32"
android:paddingEnd="24dp"
android:paddingStart="24dp"
+ android:fontFamily="sans-serif-medium"
android:textAllCaps="true"
android:textColor="@color/snackbar_button_color"
android:textSize="14sp" />
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/snackbar/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698