Chromium Code Reviews| Index: chrome/android/java/res/layout/snackbar.xml |
| diff --git a/chrome/android/java/res/layout/snackbar.xml b/chrome/android/java/res/layout/snackbar.xml |
| index 41669de0be73fa0a741ff4f92c92dd110dae6117..59908172ceb44b658d9810dea784255938aab723 100644 |
| --- a/chrome/android/java/res/layout/snackbar.xml |
| +++ b/chrome/android/java/res/layout/snackbar.xml |
| @@ -8,9 +8,7 @@ |
| android:layout_height="wrap_content" |
| android:background="#282C32" |
| android:minHeight="@dimen/snackbar_min_height" |
| - android:orientation="horizontal" |
| - android:paddingTop="14dp" |
| - android:paddingBottom="14dp" > |
| + android:orientation="horizontal" > |
| <org.chromium.chrome.browser.snackbar.TemplatePreservingTextView |
| android:id="@+id/snackbar_message" |
| @@ -18,6 +16,8 @@ |
| android:layout_height="wrap_content" |
| android:layout_gravity="start|center_vertical" |
| android:layout_marginStart="24dp" |
| + android:layout_marginTop="14dp" |
| + android:layout_marginBottom="14dp" |
| android:layout_weight="1" |
| android:textAlignment="viewStart" |
| android:textColor="@android:color/white" |
| @@ -26,11 +26,12 @@ |
| <TextView |
| android:id="@+id/snackbar_button" |
| android:layout_width="wrap_content" |
| - android:layout_height="match_parent" |
| - android:fontFamily="sans-serif-medium" |
| + android:layout_height="@dimen/snackbar_min_height" |
|
newt (away)
2015/08/08 01:11:27
how about just match_parent here?
Ian Wen
2015/08/10 22:40:10
Talked offline.
|
| + android:background="?attr/selectableItemBackground" |
|
newt (away)
2015/08/08 01:11:27
why? how does this look?
Ian Wen
2015/08/10 22:40:10
Removed.
|
| android:gravity="center_vertical" |
| android:paddingEnd="24dp" |
| android:paddingStart="24dp" |
| + android:fontFamily="sans-serif-medium" |
| android:textAllCaps="true" |
| android:textColor="@color/snackbar_button_color" |
| android:textSize="14sp" /> |