Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Issue 1284453002: Add get subcommand to buildbucket.py (Closed)

Created:
5 years, 4 months ago by smut
Modified:
5 years, 4 months ago
Reviewers:
nodir
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add get subcommand to buildbucket.py BUG=493885 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296246

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -31 lines) Patch
M buildbucket.py View 1 4 chunks +45 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
smut
5 years, 4 months ago (2015-08-07 21:06:40 UTC) #2
nodir
verified? lgtm % comment https://codereview.chromium.org/1284453002/diff/1/buildbucket.py File buildbucket.py (right): https://codereview.chromium.org/1284453002/diff/1/buildbucket.py#newcode46 buildbucket.py:46: '-i', IMO: drop this. --id ...
5 years, 4 months ago (2015-08-07 21:43:12 UTC) #3
smut
https://codereview.chromium.org/1284453002/diff/1/buildbucket.py File buildbucket.py (right): https://codereview.chromium.org/1284453002/diff/1/buildbucket.py#newcode46 buildbucket.py:46: '-i', On 2015/08/07 21:43:11, nodir wrote: > IMO: drop ...
5 years, 4 months ago (2015-08-07 21:46:48 UTC) #4
smut
On 2015/08/07 21:43:12, nodir wrote: > verified? lgtm % comment Yes. Get works, put still ...
5 years, 4 months ago (2015-08-07 21:47:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284453002/20001
5 years, 4 months ago (2015-08-07 21:50:31 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 21:52:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296246

Powered by Google App Engine
This is Rietveld 408576698