Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284433003: [UMA, Cleanup] Deprecate the UMA.GeneratedLowEntropySource histogram. (Closed)

Created:
5 years, 4 months ago by Ilya Sherman
Modified:
5 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UMA, Cleanup] Deprecate the UMA.GeneratedLowEntropySource histogram. This histogram is no longer being tracked. BUG=517206 TEST=none R=asvitkine@chromium.org Committed: https://crrev.com/6f910f1f6ce9c48c87e151d22f52ecd7f414993f Cr-Commit-Position: refs/heads/master@{#342469}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update enum labels in histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M components/metrics/metrics_state_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/metrics/metrics_state_manager.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Ilya Sherman
5 years, 4 months ago (2015-08-07 19:52:41 UTC) #1
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1284433003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1284433003/diff/1/tools/metrics/histograms/histograms.xml#oldcode46458 tools/metrics/histograms/histograms.xml:46458: <histogram name="UMA.GeneratedLowEntropySource" enum="BooleanSuccess"> Nit: Can you change this ...
5 years, 4 months ago (2015-08-07 20:09:51 UTC) #2
Ilya Sherman
https://codereview.chromium.org/1284433003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1284433003/diff/1/tools/metrics/histograms/histograms.xml#oldcode46458 tools/metrics/histograms/histograms.xml:46458: <histogram name="UMA.GeneratedLowEntropySource" enum="BooleanSuccess"> On 2015/08/07 20:09:50, Alexei Svitkine wrote: ...
5 years, 4 months ago (2015-08-07 20:16:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284433003/20001
5 years, 4 months ago (2015-08-07 20:16:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/53480)
5 years, 4 months ago (2015-08-07 21:36:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284433003/20001
5 years, 4 months ago (2015-08-07 21:42:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-07 22:54:07 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 22:55:21 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6f910f1f6ce9c48c87e151d22f52ecd7f414993f
Cr-Commit-Position: refs/heads/master@{#342469}

Powered by Google App Engine
This is Rietveld 408576698