ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc - Issue 1284433002: Revise ui::DomKey to unify character and non-character codes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc

Issue 1284433002: Revise ui::DomKey to unify character and non-character codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsDead Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/events/ozone/layout/stub/stub_keyboard_layout_engine.h ('k') | ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc

diff --git a/ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc b/ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc

index 83310a76453e7585513602a1aa1c5c199deab4fc..a1e898b03a853f7a846da0e6668f27ddb9671504 100644

--- a/ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc

+++ b/ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc

@@ -41,11 +41,9 @@ bool StubKeyboardLayoutEngine::UsesAltGr() const {

bool StubKeyboardLayoutEngine::Lookup(DomCode dom_code,

int flags,

DomKey* out_dom_key,

- base::char16* out_character,

KeyboardCode* out_key_code,

uint32* platform_keycode) const {

- return DomCodeToUsLayoutMeaning(dom_code, flags, out_dom_key, out_character,

- out_key_code);

+ return DomCodeToUsLayoutDomKey(dom_code, flags, out_dom_key, out_key_code);

}

} // namespace ui