Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: ui/events/ozone/evdev/keyboard_evdev.cc

Issue 1284433002: Revise ui::DomKey to unify character and non-character codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IsDead Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/ozone/BUILD.gn ('k') | ui/events/ozone/events_ozone.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/ozone/evdev/keyboard_evdev.cc
diff --git a/ui/events/ozone/evdev/keyboard_evdev.cc b/ui/events/ozone/evdev/keyboard_evdev.cc
index 58be1c5cfadfe50e8852fc6391f2c11b4b8e38a9..95a726d8b12c84df0416a91a4359776a354e96ca 100644
--- a/ui/events/ozone/evdev/keyboard_evdev.cc
+++ b/ui/events/ozone/evdev/keyboard_evdev.cc
@@ -212,9 +212,8 @@ void KeyboardEvdev::DispatchKey(unsigned int key,
int flags = modifiers_->GetModifierFlags();
DomKey dom_key;
KeyboardCode key_code;
- uint16 character;
uint32 platform_keycode = 0;
- if (!keyboard_layout_engine_->Lookup(dom_code, flags, &dom_key, &character,
+ if (!keyboard_layout_engine_->Lookup(dom_code, flags, &dom_key,
&key_code, &platform_keycode)) {
return;
}
@@ -224,7 +223,7 @@ void KeyboardEvdev::DispatchKey(unsigned int key,
}
KeyEvent event(down ? ET_KEY_PRESSED : ET_KEY_RELEASED, key_code, dom_code,
- modifiers_->GetModifierFlags(), dom_key, character, timestamp);
+ modifiers_->GetModifierFlags(), dom_key, timestamp);
event.set_source_device_id(device_id);
if (platform_keycode)
event.set_platform_keycode(platform_keycode);
« no previous file with comments | « ui/events/ozone/BUILD.gn ('k') | ui/events/ozone/events_ozone.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698