ui/events/keycodes/keyboard_code_conversion_xkb.h - Issue 1284433002: Revise ui::DomKey to unify character and non-character codes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/keycodes/keyboard_code_conversion_xkb.h

Issue 1284433002: Revise ui::DomKey to unify character and non-character codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsDead Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/keycodes/keyboard_code_conversion_xkb.h

diff --git a/ui/events/keycodes/keyboard_code_conversion_xkb.h b/ui/events/keycodes/keyboard_code_conversion_xkb.h

index 3ded138a2519a740b4bdfb60793120b1e58abc74..86e82f4ad59a817a2c9a4caffb85c6ee54cf6f33 100644

--- a/ui/events/keycodes/keyboard_code_conversion_xkb.h

+++ b/ui/events/keycodes/keyboard_code_conversion_xkb.h

@@ -9,12 +9,11 @@

#include "base/strings/string16.h"

#include "ui/events/events_base_export.h"

+#include "ui/events/keycodes/dom/dom_key.h"

#include "ui/events/keycodes/xkb_keysym.h"

namespace ui {

-enum class DomKey;

// Returns the DomKey associated with a non-character xkb_keysym_t.

// Returns DomKey::NONE for unrecognized keysyms, which includes

// all printable characters.

« no previous file with comments | « ui/events/keycodes/keyboard_code_conversion_x.cc ('k') | ui/events/keycodes/keyboard_code_conversion_xkb.cc » ('j') | no next file with comments »