Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Unified Diff: ui/base/ime/chromeos/character_composer_unittest.cc

Issue 1284433002: Revise ui::DomKey to unify character and non-character codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IsDead Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/chromeos/character_composer.cc ('k') | ui/events/event.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/chromeos/character_composer_unittest.cc
diff --git a/ui/base/ime/chromeos/character_composer_unittest.cc b/ui/base/ime/chromeos/character_composer_unittest.cc
index 1e305c71f03b89bb15199afba6b72b33c8cf8fb1..51b585f0eccf7cf233294b0afe680779f568ab03 100644
--- a/ui/base/ime/chromeos/character_composer_unittest.cc
+++ b/ui/base/ime/chromeos/character_composer_unittest.cc
@@ -34,7 +34,8 @@ class CharacterComposerTest : public testing::Test {
KeyEvent* DeadKeyPress(base::char16 combining_character) const {
KeyEvent* event =
new KeyEvent(ET_KEY_PRESSED, VKEY_UNKNOWN, DomCode::NONE, EF_NONE,
- DomKey::DEAD, combining_character, EventTimeForNow());
+ DomKey::DeadKeyFromCombiningCharacter(combining_character),
+ EventTimeForNow());
return event;
}
@@ -59,7 +60,7 @@ class CharacterComposerTest : public testing::Test {
int flags,
base::char16 character) const {
KeyEvent* event = new KeyEvent(ET_KEY_PRESSED, vkey, code, flags,
- CharacterToDomKey(character), character,
+ DomKey::FromCharacter(character),
EventTimeForNow());
return event;
}
« no previous file with comments | « ui/base/ime/chromeos/character_composer.cc ('k') | ui/events/event.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698