Revise ui::DomKey to unify character and non-character codes.

chrome/browser/chromeos/input_method/input_method_engine.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/input_method_engine.h"
 
 #undef FocusIn
 #undef FocusOut
 #undef RootWindow
 #include <map>
@@ skipping 291 matching lines @@
     ui::KeyboardCode key_code = static_cast<ui::KeyboardCode>(event.key_code);
     if (key_code == ui::VKEY_UNKNOWN)
       key_code = ui::DomKeycodeToKeyboardCode(event.code);
 
     int flags = ui::EF_NONE;
     flags |= event.alt_key   ? ui::EF_ALT_DOWN       : ui::EF_NONE;
     flags |= event.ctrl_key  ? ui::EF_CONTROL_DOWN   : ui::EF_NONE;
     flags |= event.shift_key ? ui::EF_SHIFT_DOWN     : ui::EF_NONE;
     flags |= event.caps_lock ? ui::EF_CAPS_LOCK_DOWN : ui::EF_NONE;
 
-    base::char16 ch = 0;
-    // 4-bytes UTF-8 string is at least 2-characters UTF-16 string.
-    // And Key char can only be single UTF-16 character.
-    if (!event.key.empty() && event.key.size() < 4) {
-      base::string16 key_char = base::UTF8ToUTF16(event.key);
-      if (key_char.size() == 1)
-        ch = key_char[0];
-    }
     ui::KeyEvent ui_event(
         type, key_code,
         ui::KeycodeConverter::CodeStringToDomCode(event.code.c_str()), flags,
-        ui::KeycodeConverter::KeyStringToDomKey(event.key.c_str()), ch,
+        ui::KeycodeConverter::KeyStringToDomKey(event.key.c_str()),

[kpschoedel, 2015/08/07 20:42:11]

KeyStringToDomKey() now handles the case where |key| contains a Unicode
character rather than a standard name.

[Wez, 2015/08/13 22:31:48]

What does it return if the string passed is neither a single Unicode code-point,
nor a non-printable key name?

[kpschoedel, 2015/08/17 20:16:14]

DomKey::NONE; this is noted in the declaration comment. In this case the effect
is the same as the previous code. I'll find a specific reviewer for this file
once the general plan is settled.

[Wez, 2015/08/18 22:34:32]

Acknowledged.

         ui::EventTimeForNow());
     base::AutoReset<const ui::KeyEvent*> reset_sent_key(&sent_key_event_,
                                                         &ui_event);
     input_method->DispatchKeyEvent(&ui_event);
   }
 
   return true;
 }
 
 const InputMethodEngine::CandidateWindowProperty&
@@ skipping 374 matching lines @@
           // TODO(nona): Implement it.
           break;
       }
     }
   }
 
   // TODO(nona): Support item.children.
 }
 
 }  // namespace chromeos