Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: content/shell/renderer/test_runner/WebTestProxy.cpp

Issue 128443002: Flood-fill the canvas used for layout tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/test_runner/WebTestProxy.cpp
diff --git a/content/shell/renderer/test_runner/WebTestProxy.cpp b/content/shell/renderer/test_runner/WebTestProxy.cpp
index 1a999e48ddf70297cbab64b29e3446477d921c5b..c47bf03238a76ee0964bd99c82f6bd241748db2d 100644
--- a/content/shell/renderer/test_runner/WebTestProxy.cpp
+++ b/content/shell/renderer/test_runner/WebTestProxy.cpp
@@ -609,7 +609,7 @@ void WebTestProxyBase::paintPagesWithBoundaries()
int pageCount = webFrame->printBegin(pageSizeInPixels);
int totalHeight = pageCount * (pageSizeInPixels.height + 1) - 1;
- SkCanvas* testCanvas = skia::TryCreateBitmapCanvas(pageSizeInPixels.width, totalHeight, true);
+ SkCanvas* testCanvas = skia::TryCreateBitmapCanvas(pageSizeInPixels.width, totalHeight, false);
if (testCanvas) {
discardBackingStore();
m_canvas.reset(testCanvas);
@@ -632,7 +632,10 @@ SkCanvas* WebTestProxyBase::canvas()
float deviceScaleFactor = webView()->deviceScaleFactor();
int scaledWidth = static_cast<int>(ceil(static_cast<float>(widgetSize.width) * deviceScaleFactor));
int scaledHeight = static_cast<int>(ceil(static_cast<float>(widgetSize.height) * deviceScaleFactor));
- m_canvas.reset(skia::CreateBitmapCanvas(scaledWidth, scaledHeight, true));
+ // We're allocating the canvas to be non-opaque (third parameter), so we
+ // don't end up with uninitialized memory if a layout test doesn't damage
+ // the entire view.
+ m_canvas.reset(skia::CreateBitmapCanvas(scaledWidth, scaledHeight, false));
return m_canvas.get();
}
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698