Flood-fill the canvas used for layout tests

content/shell/renderer/test_runner/WebTestProxy.cpp

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/test_runner/WebTestProxy.h"
 
 #include <cctype>
 
 #include "content/shell/renderer/test_runner/AccessibilityController.h"
 #include "content/shell/renderer/test_runner/EventSender.h"
@@ skipping 614 matching lines @@
 }
 
 SkCanvas* WebTestProxyBase::canvas()
 {
     if (m_canvas.get())
         return m_canvas.get();
     WebSize widgetSize = webWidget()->size();
     float deviceScaleFactor = webView()->deviceScaleFactor();
     int scaledWidth = static_cast<int>(ceil(static_cast<float>(widgetSize.width) * deviceScaleFactor));
     int scaledHeight = static_cast<int>(ceil(static_cast<float>(widgetSize.height) * deviceScaleFactor));
     m_canvas.reset(skia::CreateBitmapCanvas(scaledWidth, scaledHeight, true));

[reed1, 2014/01/08 15:49:17]

I think you want to just pass 'false' to CreateBitmapCanvas. Otherwise, you
claiming to skia that all the pixels will be opaque, which tells skia to ignore
reading the alpha values during compositing.

By passing false, skia will flood-fill the pxiels with zero for you (and
potentially faster than you can, when we start using calloc. WIth 'false', you
won't need to call drawARGB().

[jochen (gone - plz use gerrit), 2014/01/08 18:03:52]

Done.

+    m_canvas->drawARGB(0, 0, 0, 0);
     return m_canvas.get();
 }
 
 // Paints the entire canvas a semi-transparent black (grayish). This is used
 // by the layout tests in fast/repaint. The alpha value matches upstream.
 void WebTestProxyBase::displayRepaintMask()
 {
     canvas()->drawARGB(167, 0, 0, 0);
 }
 
@@ skipping 712 matching lines @@
 
 void WebTestProxyBase::resetInputMethod()
 {
     // If a composition text exists, then we need to let the browser process
     // to cancel the input method's ongoing composition session.
     if (m_webWidget)
         m_webWidget->confirmComposition();
 }
 
 }