Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1284423005: Revert of Sync GN unit tests with GYP, add checking script. (Closed)

Created:
5 years, 4 months ago by msramek
Modified:
5 years, 4 months ago
Reviewers:
brettw, jam
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Sync GN unit tests with GYP, add checking script. (patchset #3 id:40001 of https://codereview.chromium.org/1289423004/ ) Reason for revert: Breakage of tests on Linux GN. See crbug.com/521944 for more details. Original issue's description: > Sync GN unit tests with GYP, add checking script. > > Some of these JavaScript gtest tests were missing from the GN build because > they needed to go into a special target. > > The included script will find and print out lists of test differences. > > Committed: https://crrev.com/b2f72715a4899c690f92529f91fa3a9adf9db5ff > Cr-Commit-Position: refs/heads/master@{#343820} TBR=jam@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=521944 Committed: https://crrev.com/28fccd5cbdec7e4c1a38d07926591da41331d7d8 Cr-Commit-Position: refs/heads/master@{#343886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -106 lines) Patch
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/gn/bin/compare_test_lists.py View 1 chunk +0 lines, -101 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
msramek
Created Revert of Sync GN unit tests with GYP, add checking script.
5 years, 4 months ago (2015-08-18 11:29:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284423005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284423005/1
5 years, 4 months ago (2015-08-18 11:30:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 11:30:29 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 11:31:15 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28fccd5cbdec7e4c1a38d07926591da41331d7d8
Cr-Commit-Position: refs/heads/master@{#343886}

Powered by Google App Engine
This is Rietveld 408576698