Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1284423004: Initializes _data in constructor (Closed)

Created:
5 years, 4 months ago by eernst
Modified:
5 years, 4 months ago
Reviewers:
floitsch, sigurdm
CC:
eernst+reviews_google.com, reviews_dartlang.org, sigurdm
Base URL:
https://github.com/dart-lang/reflectable.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Now initializing _data in constructor .. rather than initializing a cache for it lazily and repeatedly checking whether the cache has been initialized.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -32 lines) Patch
M reflectable/lib/src/mirrors_unimpl.dart View 7 chunks +24 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eernst
Changes the treatment of data[_reflector] in several types of mirrors such that it is computed ...
5 years, 4 months ago (2015-08-18 10:27:55 UTC) #2
sigurdm
lgtm
5 years, 4 months ago (2015-08-18 10:36:10 UTC) #4
eernst
Unfortunately, the code generated as `"r.data = ${code};"` now makes an attempt to access `r.data` ...
5 years, 4 months ago (2015-08-18 11:25:37 UTC) #5
eernst
This experiment shows why we cannot easily eliminate the lazy initialization of `_data` in certain ...
5 years, 4 months ago (2015-08-18 11:27:13 UTC) #6
floitsch
5 years, 4 months ago (2015-08-18 12:10:58 UTC) #7
On 2015/08/18 11:27:13, eernst wrote:
> This experiment shows why we cannot easily eliminate the lazy initialization
of
> `_data` in certain mirrors after all: Let's just drop this CL and keep the
lazy
> initialization.

too bad.

Powered by Google App Engine
This is Rietveld 408576698