Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1284423002: Remove app_name.xml. (Closed)

Created:
5 years, 4 months ago by newt (away)
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove app_name.xml. The resource "@string/app_name" is already defined in chrome/android/java/res_default/values/channel_constants.xml. No need to define it twice; in fact, aapt doesn't like if we define it twice. Committed: https://crrev.com/16efbc51849de095040e567563003d938ecccbcc Cr-Commit-Position: refs/heads/master@{#343113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
D chrome/android/java/res/values/app_name.xml View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
newt (away)
PTAL
5 years, 4 months ago (2015-08-12 21:53:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284423002/1
5 years, 4 months ago (2015-08-12 21:54:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-12 22:05:04 UTC) #6
David Trainor- moved to gerrit
lgtm
5 years, 4 months ago (2015-08-12 22:19:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284423002/1
5 years, 4 months ago (2015-08-12 22:24:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 22:30:08 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 22:30:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16efbc51849de095040e567563003d938ecccbcc
Cr-Commit-Position: refs/heads/master@{#343113}

Powered by Google App Engine
This is Rietveld 408576698